[#330] Replace bonding curve chart with real price history#335
Merged
realproject7 merged 1 commit intomainfrom Mar 18, 2026
Merged
[#330] Replace bonding curve chart with real price history#335realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
- PriceChart now queries trade_history table for actual price data - SVG line chart with time on X-axis, price on Y-axis - Current price marked with pulsing ring animation (pure SVG) - Empty state: pulsing dot + "No trading activity yet" message - Downsamples to 50 points for large datasets - Heading changed from "Price Curve" to "Price" - Removed totalSupplyRaw prop, updated parent page Fixes #330 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 18, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Clean rewrite, all acceptance criteria met:
- Queries
trade_historybytoken_address, ordered byblock_timestamp✅ - SVG pulse animation on last data point (expanding ring + fade) ✅
- Empty state: pulsing dot + "No trading activity yet" + current price fallback ✅
totalSupplyRawprop removed from interface + both parent usages ✅- Heading: "Price Curve" → "Price" ✅
- Terminal/monospace/green aesthetic preserved ✅
- Downsampling (~50 points) handles large datasets ✅
- Y-axis scaling with 10% padding avoids clipping
- Time labels adapt: HH:MM for <1 day, MMM DD for older
- Single-point edge case handled via
|| 1divisor guard
project7-interns
approved these changes
Mar 18, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This PR correctly replaces the synthetic bonding-curve chart with a real trade_history time-series chart while preserving the existing SVG/terminal aesthetic. The prop cleanup and empty-state fallback are both in scope and coherent.
Findings
- [low]
PriceChartnow readstrade_historydirectly, downsamples for dense histories, and keeps the requested pulsing latest-point marker in pure SVG.- File:
src/components/PriceChart.tsx:39 - Suggestion: None.
- File:
- [low] Parent usage was updated consistently to drop the obsolete
totalSupplyRawprop.- File:
src/app/story/[storylineId]/page.tsx:172 - Suggestion: None.
- File:
Decision
Approve. The chart now uses real historical trade data, the empty state is clean, the heading is Price, and local npm run build plus npm run typecheck both pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trade_historytable for real price-over-time data<animate>)totalSupplyRaw, updated story detail page2 files changed. Same terminal/monospace aesthetic preserved.
Fixes #330
Test plan
npm run buildpassesnpm run typecheckpasses